Add SQLQuery Utils support for Vaccum queries#3269
Merged
noCharger merged 3 commits intoopensearch-project:mainfrom Apr 11, 2025
Merged
Add SQLQuery Utils support for Vaccum queries#3269noCharger merged 3 commits intoopensearch-project:mainfrom
noCharger merged 3 commits intoopensearch-project:mainfrom
Conversation
Siritejagaddameedi
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
ykmr1224
reviewed
Jan 28, 2025
Collaborator
ykmr1224
left a comment
ykmr1224
left a comment
There was a problem hiding this comment.
Please add DCO, and unit tests.
Collaborator
|
Build failed due to style check. |
noCharger
reviewed
Jan 29, 2025
Comment on lines
318
to
343
| @Override | ||
| public Void visitVacuumCoveringIndexStatement( | ||
| FlintSparkSqlExtensionsParser.VacuumCoveringIndexStatementContext ctx) { | ||
| indexQueryDetailsBuilder.indexQueryActionType(IndexQueryActionType.VACUUM); | ||
| indexQueryDetailsBuilder.indexType(FlintIndexType.COVERING); | ||
| return super.visitVacuumCoveringIndexStatement(ctx); | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitVacuumSkippingIndexStatement( | ||
| FlintSparkSqlExtensionsParser.VacuumSkippingIndexStatementContext ctx) { | ||
| indexQueryDetailsBuilder.indexQueryActionType(IndexQueryActionType.VACUUM); | ||
| indexQueryDetailsBuilder.indexType(FlintIndexType.SKIPPING); | ||
| return super.visitVacuumSkippingIndexStatement(ctx); | ||
| } | ||
|
|
||
| @Override | ||
| public Void visitVacuumMaterializedViewStatement( | ||
| FlintSparkSqlExtensionsParser.VacuumMaterializedViewStatementContext ctx) { | ||
| indexQueryDetailsBuilder.indexQueryActionType(IndexQueryActionType.VACUUM); | ||
| indexQueryDetailsBuilder.indexType(FlintIndexType.MATERIALIZED_VIEW); | ||
| indexQueryDetailsBuilder.mvName(ctx.mvName.getText()); | ||
| return super.visitVacuumMaterializedViewStatement(ctx); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
what's the use case for adding Vaccum in async-query-core?
Contributor
Author
There was a problem hiding this comment.
Whenever we call SQLQueryUtils with vacuum query, it will fail to parse the query.
Siritejagaddameedi
force-pushed
the
iris_vaccum
branch
from
d2ac2fa to
f8642a5
Compare
ykmr1224
approved these changes
Jan 30, 2025
ykmr1224
requested changes
Jan 30, 2025
Collaborator
ykmr1224
left a comment
ykmr1224
left a comment
There was a problem hiding this comment.
I think you want to make this change against main branch instead of 2.x and we'll backport to 2.x once merged.
7 tasks
Siritejagaddameedi
force-pushed
the
iris_vaccum
branch
from
f8642a5 to
e86f4b6
Compare
noCharger
reviewed
Apr 8, 2025
Collaborator
noCharger
left a comment
noCharger
left a comment
There was a problem hiding this comment.
Thanks for the change! Let's fix the DCO and add the necessary test cases, for example https://github.com/opensearch-project/sql/pull/2985/files#diff-4aba5e85641e1ff025d49ef65ad0eb29a5db4bb00d4a3d3f90ccf55a925b5a8f
Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com> Add UTs Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com> Fix build Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com> Fix code style Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com>
Siritejagaddameedi
force-pushed
the
iris_vaccum
branch
from
f3496e7 to
532e90a
Compare
ykmr1224
approved these changes
Apr 11, 2025
noCharger
approved these changes
Apr 11, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
Add UTs Fix build Fix code style Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com> Co-authored-by: Siri Teja Gaddameedi <sirigadd@amazon.com> (cherry picked from commit e23a61d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger
pushed a commit
that referenced
this pull request
Apr 21, 2025
Add UTs Fix build Fix code style (cherry picked from commit e23a61d) Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siri Teja Gaddameedi <sirigadd@amazon.com>
7 tasks
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
Add UTs Fix build Fix code style Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com> Co-authored-by: Siri Teja Gaddameedi <sirigadd@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add SQLQueryUtils support for Vacuum queries
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.